netdev - Re: [PATCH v2 iwl-net 1/2] idpf: fix memory leak of flow steer list on rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izOW+TxLU9dzy08g8MBE+cZGeXwsPnrq7wWH_XrCzHHp7A@mail.gmail.com>
Date: Wed, 17 Dec 2025 16:56:47 -0800
From: Mina Almasry <almasrymina@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: Sreedevi Joshi <sreedevi.joshi@...el.com>, intel-wired-lan@...ts.osuosl.org, 
	netdev@...r.kernel.org, Przemek Kitszel <przemyslaw.kitszel@...el.com>, 
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH v2 iwl-net 1/2] idpf: fix memory leak of flow steer list
 on rmmod

On Wed, Oct 1, 2025 at 8:44 AM Simon Horman <horms@...nel.org> wrote:
>
> On Tue, Sep 30, 2025 at 04:23:51PM -0500, Sreedevi Joshi wrote:
> > The flow steering list maintains entries that are added and removed as
> > ethtool creates and deletes flow steering rules. Module removal with active
> > entries causes memory leak as the list is not properly cleaned up.
> >
> > Prevent this by iterating through the remaining entries in the list and
> > freeing the associated memory during module removal. Add a spinlock
> > (flow_steer_list_lock) to protect the list access from multiple threads.
> >
> > Fixes: ada3e24b84a0 ("idpf: add flow steering support")
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> > Signed-off-by: Sreedevi Joshi <sreedevi.joshi@...el.com>
>
> Reviewed-by: Simon Horman <horms@...nel.org>
>

Tested-by: Mina Almasry <almasrymina@...gle.com>


-- 
Thanks,
Mina