netdev - Re: net/sched: Fix divide error in tabledist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251221090310.60bc803d@phoenix.local>
Date: Sun, 21 Dec 2025 09:03:10 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Manas Ghandat <ghandatmanas@...il.com>
Cc: xiyou.wangcong@...il.com, Jiri Pirko <jiri@...nulli.us>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: net/sched: Fix divide error in tabledist

On Wed, 17 Dec 2025 23:57:40 +0530
Manas Ghandat <ghandatmanas@...il.com> wrote:

> Just a friendly reminder
> 
> On 12/12/25 20:47, Manas Ghandat wrote:
> >
> > On 12/12/25 13:48, Stephen Hemminger wrote:  
> >> The whole netem_in_tree check is problematic as well.  
> > Can you mention the issues. Maybe I can include that in my patch as well.  
> >> Your mail system is corrupting the patch.  
> > I will resend the patch.  
> >> Is this the same as earlier patch  
> > I have just moved the check before the values in qdisc are changed. 
> > This would prevent the values being affected in case we bail out 
> > taking the error path.  

The check_netem_in_tree code caused a regression where some valid configurations
using multiple queues are HTB stopped working.  A better solution is needed
and Cong et al are working on it.