netdev - Re: [PATCH net 2/2] selftests: fib_nexthops: Add test cases for error routes deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0bb9f0dd-686b-4034-aa64-71247b523725@kernel.org>
Date: Mon, 22 Dec 2025 18:13:12 -0500
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, horms@...nel.org, penguin-kernel@...ove.SAKURA.ne.jp
Subject: Re: [PATCH net 2/2] selftests: fib_nexthops: Add test cases for error
 routes deletion

On 12/21/25 7:48 AM, Ido Schimmel wrote:
> Add test cases that check that error routes (e.g., blackhole) are
> deleted when their nexthop is deleted.
> 
> Output without "ipv4: Fix reference count leak when using error routes
> with nexthop objects":
> 
>  # ./fib_nexthops.sh -t "ipv4_fcnal ipv6_fcnal"
> 
>  IPv4 functional
>  ----------------------
>  [...]
>        WARNING: Unexpected route entry
>  TEST: Error route removed on nexthop deletion                       [FAIL]
> 
>  IPv6
>  ----------------------
>  [...]
>  TEST: Error route removed on nexthop deletion                       [ OK ]
> 
>  Tests passed:  20
>  Tests failed:   1
>  Tests skipped:  0
> 
> Output with "ipv4: Fix reference count leak when using error routes
> with nexthop objects":
> 
>  # ./fib_nexthops.sh -t "ipv4_fcnal ipv6_fcnal"
> 
>  IPv4 functional
>  ----------------------
>  [...]
>  TEST: Error route removed on nexthop deletion                       [ OK ]
> 
>  IPv6
>  ----------------------
>  [...]
>  TEST: Error route removed on nexthop deletion                       [ OK ]
> 
>  Tests passed:  21
>  Tests failed:   0
>  Tests skipped:  0
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/fib_nexthops.sh | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>