netdev - Re: [PATCH net v3] net: nfc: nci: Fix parameter validation for packet data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <059d9fbb-7383-441c-9368-1c96eafae1f8@linux.dev>
Date: Mon, 22 Dec 2025 15:21:59 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Michael Thalmeier <michael.thalmeier@...e.at>,
 Deepak Sharma <deepak.sharma.472935@...il.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, Simon Horman <horms@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Michael Thalmeier <michael@...lmeier.at>, stable@...r.kernel.org
Subject: Re: [PATCH net v3] net: nfc: nci: Fix parameter validation for packet
 data

On 22/12/2025 14:31, Michael Thalmeier wrote:
> @@ -668,6 +679,11 @@ static int nci_rf_intf_activated_ntf_packet(struct nci_dev *ndev,
>   		}
>   	}
>   
> +	if (skb->len < (data - skb->data) + sizeof(ntf.data_exch_rf_tech_and_mode) +
> +				sizeof(ntf.data_exch_tx_bit_rate) + sizeof (ntf.data_exch_rx_bit_rate) +

extra space between sizeof and the bracket

> +				sizeof(ntf.activation_params_len))
> +		return -EINVAL;
> +
>   	ntf.data_exch_rf_tech_and_mode = *data++;
>   	ntf.data_exch_tx_bit_rate = *data++;
>   	ntf.data_exch_rx_bit_rate = *data++;