netdev - Re: [PATCH v2 16/19] dt-bindings: pinctrl: pinctrl-microchip-sgpio: add LAN969x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251222-outsell-demotion-97b03a1bf42e@spud>
Date: Mon, 22 Dec 2025 20:52:15 +0000
From: Conor Dooley <conor@...nel.org>
To: Robert Marko <robert.marko@...tura.hr>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
	claudiu.beznea@...on.dev, Steen.Hegelund@...rochip.com,
	daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
	herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org,
	linux@...ck-us.net, andi.shyti@...nel.org, lee@...nel.org,
	andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linusw@...nel.org, olivia@...enic.com,
	radu_nicolae.pirea@....ro, richard.genoud@...tlin.com,
	gregkh@...uxfoundation.org, jirislaby@...nel.org,
	mturquette@...libre.com, sboyd@...nel.org, richardcochran@...il.com,
	wsa+renesas@...g-engineering.com, romain.sioen@...rochip.com,
	Ryan.Wanner@...rochip.com, lars.povlsen@...rochip.com,
	tudor.ambarus@...aro.org, charan.pedumuru@...rochip.com,
	kavyasree.kotagiri@...rochip.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-hwmon@...r.kernel.org, linux-i2c@...r.kernel.org,
	netdev@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-clk@...r.kernel.org,
	mwalle@...nel.org, luka.perkov@...tura.hr
Subject: Re: [PATCH v2 16/19] dt-bindings: pinctrl: pinctrl-microchip-sgpio:
 add LAN969x

On Mon, Dec 22, 2025 at 08:57:14PM +0100, Robert Marko wrote:
> On Tue, Dec 16, 2025 at 6:34 PM Conor Dooley <conor@...nel.org> wrote:
> >
> > On Mon, Dec 15, 2025 at 05:35:33PM +0100, Robert Marko wrote:
> > > Document LAN969x compatibles for SGPIO.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> > > ---
> > >  .../pinctrl/microchip,sparx5-sgpio.yaml       | 20 ++++++++++++++-----
> > >  1 file changed, 15 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > index fa47732d7cef..9fbbafcdc063 100644
> > > --- a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > +++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
> > > @@ -21,10 +21,15 @@ properties:
> > >      pattern: '^gpio@[0-9a-f]+$'
> > >
> > >    compatible:
> > > -    enum:
> > > -      - microchip,sparx5-sgpio
> > > -      - mscc,ocelot-sgpio
> > > -      - mscc,luton-sgpio
> > > +    oneOf:
> > > +      - enum:
> > > +          - microchip,sparx5-sgpio
> > > +          - mscc,ocelot-sgpio
> > > +          - mscc,luton-sgpio
> > > +      - items:
> > > +          - enum:
> > > +              - microchip,lan9691-sgpio
> > > +          - const: microchip,sparx5-sgpio
> > >
> > >    '#address-cells':
> > >      const: 1
> > > @@ -80,7 +85,12 @@ patternProperties:
> > >      type: object
> > >      properties:
> > >        compatible:
> > > -        const: microchip,sparx5-sgpio-bank
> >
> > This should just be able to become "compatible: contains: const: microchip,sparx5-sgpio-bank.
> > pw-bot: changes-requested
> 
> Hi Conor,
> I have tried using contains, but it would fail to match with the
> following error:
> arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dtb:
> /axi/gpio@...10230/gpio@0: failed to match any schema with compatible:
> ['microchip,lan9691-sgpio-bank', 'microchip,sparx5-sgpio-bank']
> arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dtb:
> /axi/gpio@...10230/gpio@1: failed to match any schema with compatible:
> ['microchip,lan9691-sgpio-bank', 'microchip,sparx5-sgpio-bank']

Oh, I think I cocked up here and thought this was some restriction
imposition but it's a child with a compatible. My bad.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)