netdev - Re: [PATCH v2] net: usb: sr9700: fix incorrect command used to write single register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADkSEUgwA9=2fZQzDU51e71rxSHgCUPjQMEWbnOWJ1LOQFDa2A@mail.gmail.com>
Date: Mon, 22 Dec 2025 16:30:35 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: usb: sr9700: fix incorrect command used to write
 single register

On Mon, Dec 22, 2025 at 1:07 AM Andrew Lunn <andrew@...n.ch> wrote:
> Please don't top post.

Sorry. I will keep that in mind in the future.

> How finished do you think this driver is? Are there likely to be more
> instances of SR_WR_REG/SR_WR_REGS added in the future? If so, it might
> make sense to change the code to make this sort of error less likely.
>
> SR_WR_MULTIPLE_REG and SR_WR_ONE_REG?

That's a good idea. This driver has significant functional issues
because it is a copy of the dm9601 driver, but the hardware, while
generally a DM9601 clone, does not support some features of the DM9601
(for example, it has no MII or multicast filter registers). I am
probing the registers to check which registers/bits are present and
work as expected (going by the DM9601 datasheet). When I finish doing
so and submit a patch to fix these issues, I will change the names of
those constants.