netdev - Re: [PATCH net v1] net: phy: mxl-86110: Add power management and soft reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91d7740a-b340-449d-98e3-d3cf0aae5f78@redhat.com>
Date: Tue, 23 Dec 2025 12:28:06 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Stefano Radaelli <stefano.radaelli21@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Stefano Radaelli <stefano.r@...iscite.com>, Xu Liang <lxu@...linear.com>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net v1] net: phy: mxl-86110: Add power management and soft
 reset support

On 12/16/25 5:25 PM, Stefano Radaelli wrote:
> Implement soft_reset, suspend, and resume callbacks using
> genphy_soft_reset(), genphy_suspend(), and genphy_resume()
> to fix PHY initialization and power management issues.
> 
> The soft_reset callback is needed to properly recover the PHY after an
> ifconfig down/up cycle. Without it, the PHY can remain in power-down
> state, causing MDIO register access failures during config_init().
> The soft reset ensures the PHY is operational before configuration.
> 
> The suspend/resume callbacks enable proper power management during
> system suspend/resume cycles.
> 
> Fixes: b2908a989c59 ("net: phy: add driver for MaxLinear MxL86110 PHY")
> Signed-off-by: Stefano Radaelli <stefano.r@...iscite.com>

You need to add a suitable  From: tag at the body start, or use the same
email address as the sender, whatever you prefer.

Also the resume/callback bits are IMHO more new features than fixes, but
I will not push back hard against them.

Thanks,

Paolo