netdev - Re: [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251224-berserk-mackerel-of-snow-4cae54@quoll>
Date: Wed, 24 Dec 2025 11:21:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Robert Marko <robert.marko@...tura.hr>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com, claudiu.beznea@...on.dev, 
	herbert@...dor.apana.org.au, davem@...emloft.net, vkoul@...nel.org, andi.shyti@...nel.org, 
	lee@...nel.org, andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, linusw@...nel.org, Steen.Hegelund@...rochip.com, 
	daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com, olivia@...enic.com, 
	radu_nicolae.pirea@....ro, richard.genoud@...tlin.com, gregkh@...uxfoundation.org, 
	jirislaby@...nel.org, broonie@...nel.org, mturquette@...libre.com, sboyd@...nel.org, 
	lars.povlsen@...rochip.com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org, 
	linux-i2c@...r.kernel.org, netdev@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-spi@...r.kernel.org, linux-serial@...r.kernel.org, linux-usb@...r.kernel.org, 
	linux-clk@...r.kernel.org, luka.perkov@...tura.hr
Subject: Re: [PATCH v3 01/15] include: dt-bindings: add LAN969x clock bindings

On Tue, Dec 23, 2025 at 09:16:12PM +0100, Robert Marko wrote:
> Add the required LAN969x clock bindings.

I do not see clock bindings actually here. Where is the actual binding?
Commit msg does not help me at all to understand why you are doing this
without actual required bindings.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Bindings never have a "include" prefix.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof