netdev - Re: [PATCH v2 net] net: enetc: do not print error log if addr is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251228193838.pevckwqcqooyd7ir@skbuf>
Date: Sun, 28 Dec 2025 21:38:38 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Wei Fang <wei.fang@....com>
Cc: claudiu.manoil@....com, xiaoning.wang@....com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH v2 net] net: enetc: do not print error log if addr is 0

On Mon, Dec 22, 2025 at 10:26:28AM +0800, Wei Fang wrote:
> A value of 0 for addr indicates that the IEB_LBCR register does not
> need to be configured, as its default value is 0. However, the driver
> will print an error log if addr is 0, so this issue needs to be fixed.
> 
> Fixes: 50bfd9c06f0f ("net: enetc: set external PHY address in IERB for i.MX94 ENETC")
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---
> v2 changes:
> Separate tests for "if (addr < 0)" and a later "if (!addr)".
> v1: https://lore.kernel.org/imx/20251219082922.3883800-1-wei.fang@nxp.com/
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>