netdev - Re: [PATCH v3] net/ena: fix missing lock when update devlink params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <auk6ifnbjy7xhmv5il5mhkttlg2sgvj2fqmmryt53pf7ifhga2@a6m25efjduln>
Date: Fri, 2 Jan 2026 10:41:31 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Xiao Liang <xiliang@...hat.com>
Cc: shayagr@...zon.com, akiyano@...zon.com, darinzon@...zon.com, 
	saeedb@...zon.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net/ena: fix missing lock when update devlink params

Wed, Dec 31, 2025 at 03:58:08PM +0100, xiliang@...hat.com wrote:
>From: Frank Liang <xiliang@...hat.com>
>
>Fix assert lock warning while calling devl_param_driverinit_value_set()
>in ena.
>
>WARNING: net/devlink/core.c:261 at devl_assert_locked+0x62/0x90, CPU#0: kworker/0:0/9
>CPU: 0 UID: 0 PID: 9 Comm: kworker/0:0 Not tainted 6.19.0-rc2+ #1 PREEMPT(lazy)
>Hardware name: Amazon EC2 m8i-flex.4xlarge/, BIOS 1.0 10/16/2017
>Workqueue: events work_for_cpu_fn
>RIP: 0010:devl_assert_locked+0x62/0x90
>
>Call Trace:
> <TASK>
> devl_param_driverinit_value_set+0x15/0x1c0
> ena_devlink_alloc+0x18c/0x220 [ena]
> ? __pfx_ena_devlink_alloc+0x10/0x10 [ena]
> ? trace_hardirqs_on+0x18/0x140
> ? lockdep_hardirqs_on+0x8c/0x130
> ? __raw_spin_unlock_irqrestore+0x5d/0x80
> ? __raw_spin_unlock_irqrestore+0x46/0x80
> ? devm_ioremap_wc+0x9a/0xd0
> ena_probe+0x4d2/0x1b20 [ena]
> ? __lock_acquire+0x56a/0xbd0
> ? __pfx_ena_probe+0x10/0x10 [ena]
> ? local_clock+0x15/0x30
> ? __lock_release.isra.0+0x1c9/0x340
> ? mark_held_locks+0x40/0x70
> ? lockdep_hardirqs_on_prepare.part.0+0x92/0x170
> ? trace_hardirqs_on+0x18/0x140
> ? lockdep_hardirqs_on+0x8c/0x130
> ? __raw_spin_unlock_irqrestore+0x5d/0x80
> ? __raw_spin_unlock_irqrestore+0x46/0x80
> ? __pfx_ena_probe+0x10/0x10 [ena]
> ......
> </TASK>
>
>Fixes: 816b52624cf6 ("net: ena: Control PHC enable through devlink")
>Signed-off-by: Frank Liang <xiliang@...hat.com>
>Reviewed-by: David Arinzon <darinzon@...zon.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>