netdev - Re: [PATCH net-next v2] page_pool: Add page_pool_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260102104504.7f593441@gandalf.local.home>
Date: Fri, 2 Jan 2026 10:45:04 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Leon Hwang <leon.hwang@...ux.dev>
Cc: netdev@...r.kernel.org, Jesper Dangaard Brouer <hawk@...nel.org>, Ilias
 Apalodimas <ilias.apalodimas@...aro.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 kerneljasonxing@...il.com, lance.yang@...ux.dev, jiayuan.chen@...ux.dev,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, Leon
 Huang Fu <leon.huangfu@...pee.com>
Subject: Re: [PATCH net-next v2] page_pool: Add page_pool_release_stalled
 tracepoint

On Fri,  2 Jan 2026 14:17:18 +0800
Leon Hwang <leon.hwang@...ux.dev> wrote:

> diff --git a/include/trace/events/page_pool.h b/include/trace/events/page_pool.h
> index 31825ed30032..c34de6a5ae80 100644
> --- a/include/trace/events/page_pool.h
> +++ b/include/trace/events/page_pool.h
> @@ -113,6 +113,30 @@ TRACE_EVENT(page_pool_update_nid,
>  		  __entry->pool, __entry->pool_nid, __entry->new_nid)
>  );
>  
> +TRACE_EVENT(page_pool_release_stalled,
> +
> +	TP_PROTO(const struct page_pool *pool, int inflight, int sec),
> +
> +	TP_ARGS(pool, inflight, sec),
> +
> +	TP_STRUCT__entry(
> +		__field(const struct page_pool *, pool)
> +		__field(u32,			  id)
> +		__field(int,			  inflight)
> +		__field(int,			  sec)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->pool		= pool;
> +		__entry->id		= pool->user.id;
> +		__entry->inflight	= inflight;
> +		__entry->sec		= sec;
> +	),
> +
> +	TP_printk("page_pool=%p id=%d inflight=%d sec=%d",
> +		  __entry->pool, __entry->id, __entry->inflight, __entry->sec)
> +);
> +
>  #endif /* _TRACE_PAGE_POOL_H */

From a tracing POV, I see nothing wrong with this.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve