netdev - Re: [DISCUSS] tg3 reboot handling on Dell T440 (BCM5720)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFE8DLTGB5Q0.1184HJSQ0DHK2@pve>
Date: Fri, 02 Jan 2026 18:22:58 +0200
From: "Noam D. Eliyahu" <noam.d.eliyahu@...il.com>
To: "Pavan Chebbi" <pavan.chebbi@...adcom.com>
Cc: <mchan@...adcom.com>, <netdev@...r.kernel.org>, "George Shuklin"
 <george.shuklin@...il.com>, "Lenny Szubowicz" <lszubowi@...hat.com>
Subject: Re: [DISCUSS] tg3 reboot handling on Dell T440 (BCM5720)

On Wed Dec 31, 2025 at 5:10 PM IST, Pavan Chebbi wrote:
> OK I now understand. You make a lucid argument. 9fc3bc764334 does
> indicate that the problem it is trying to fix is very much limited to
> R650xs.
Indeed AER suppression is needed only because of the conditional
tg3_power_down.

So both the conditional tg3_power_down and the AER suppression should
be scoped only to the platforms that originally required them.
This preserves the intent of the original commits while avoiding
whitelist maintenance and reflecting the relationship between the two bugs.

> Hence while I am almost sure that your proposal (about adding
> conditional tg3_power_down for R650xs alone) won't break anything for
> cc: George, we need an ack from cc: Lenny, to see if he is OK with an
> unconditional power down, and that he had no other motive to disable
> AER in tg3 config space. In all possible logic, it should just be fine
> because e0efe83ed3252 is fixing 9fc3bc764334.
Sounds great!
I'll wait for an ACK from Lenny confirming that this approach -
limiting both conditional tg3_power_down and AER suppression to the
affected platforms - works for his setups and doesn't need broader
application.

> P.S Sorry for the delayed reply. I am on vacation.
Totally reasonable - between Christmas and the New Year, I haven't been
very active myself.

Wishing everyone a happy and hopefully reboot-hang-free start to the New Year!

If it helps, I can provide a pre-approved patch so George or Lenny can
test it on their hardware before I try to commit one.

Thanks,
Noam D. Eliyahu