netdev - Re: [PATCH net] net: bnge: add AUXILIARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHLZf_tQbddDms1tnVvRj7EP7vUm5qwoDN0puu-pusWS7+PWPQ@mail.gmail.com>
Date: Sun, 4 Jan 2026 22:22:36 +0530
From: Vikas Gupta <vikas.gupta@...adcom.com>
To: Markus Blöchl <markus@...chl.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Leon Romanovsky <leon@...nel.org>, Siva Reddy Kallam <siva.kallam@...adcom.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: bnge: add AUXILIARY_BUS to Kconfig dependencies

On Sun, Dec 28, 2025 at 9:23 PM Markus Blöchl <markus@...chl.de> wrote:
>
> The build can currently fail with
>
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_add':
>     bnge_auxr.c:(.text+0x366): undefined reference to `__auxiliary_device_add'
>     ld: drivers/net/ethernet/broadcom/bnge/bnge_auxr.o: in function `bnge_rdma_aux_device_init':
>     bnge_auxr.c:(.text+0x43c): undefined reference to `auxiliary_device_init'
>
> if BNGE is enabled but no other driver pulls in AUXILIARY_BUS.
>
> Select AUXILIARY_BUS in BNGE like in all other drivers which create
> an auxiliary_device.
>
> Fixes: 8ac050ec3b1c ("bng_en: Add RoCE aux device support")
> Signed-off-by: Markus Blöchl <markus@...chl.de>

Reviewed-by: Vikas Gupta <vikas.gupta@...adcom.com>

> ---
> Basic steps to reproduce:
> - make allnoconfig
> - manually enable just PCI, NETDEVICES, ETHERNET, NET_VENDOR_BROADCOM and BNGE
> - make
> ---
>  drivers/net/ethernet/broadcom/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index ca565ace6e6a..cd7dddeb91dd 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -259,6 +259,7 @@ config BNGE
>         depends on PCI
>         select NET_DEVLINK
>         select PAGE_POOL
> +       select AUXILIARY_BUS
>         help
>           This driver supports Broadcom ThorUltra 50/100/200/400/800 gigabit
>           Ethernet cards. The module will be called bng_en. To compile this
>
> ---
> base-commit: 4d1442979e4a53b9457ce1e373e187e1511ff688
> change-id: 20251228-bnge_aux_bus-4acb743203b5
>
> Best regards,
> --
> Markus Blöchl <markus@...chl.de>
>
>
> --

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5465 bytes)