netdev - Re: [PATCH net] net: airoha: Fix schedule while atomic in airoha_ppe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVt3P_sAeb0UtshZ@lore-rh-laptop>
Date: Mon, 5 Jan 2026 09:33:03 +0100
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: airoha: Fix schedule while atomic in
 airoha_ppe_deinit()

> On Tue, 23 Dec 2025 22:56:44 +0100 Lorenzo Bianconi wrote:
> > Rely on rcu_replace_pointer in airoha_ppe_deinit routine in order to fix
> > schedule while atomic issue.
> 
> The information in the commit message is not sufficient.
> What "schedule while atomic issue"?

The issue is we run kzalloc() with GFP_KERNEL in airoha_npu_ppe_deinit()
in atomic context but we do not really need atomic context there.
I will fix the commit log in v2.

Regards,
Lorenzo

> 
> > -	npu = rcu_dereference(eth->npu);
> > +	mutex_lock(&flow_offload_mutex);
> > +
> > +	npu = rcu_replace_pointer(eth->npu, NULL,
> > +				  lockdep_is_held(&flow_offload_mutex));
> >  	if (npu) {
> >  		npu->ops.ppe_deinit(npu);
> >  		airoha_npu_put(npu);
> -- 
> pw-bot: cr

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)