netdev - Re: [PATCH v2] can: ctucanfd: fix SSP_SRC in cases when bit-rate is higher than 1 MBit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260105-rare-imported-hyrax-b2e3e2-mkl@pengutronix.de>
Date: Mon, 5 Jan 2026 13:49:46 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Pavel Pisa <pisa@....cvut.cz>
Cc: linux-can@...r.kernel.org, David Laight <david.laight.linux@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Andrea Daoud <andreadaoud6@...il.com>, 
	Wolfgang Grandegger <wg@...ndegger.com>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Jiri Novak <jnovak@....cvut.cz>, Ondrej Ille <ondrej.ille@...il.com>
Subject: Re: [PATCH v2] can: ctucanfd: fix SSP_SRC in cases when bit-rate is
 higher than 1 MBit.

On 05.01.2026 12:16:20, Pavel Pisa wrote:
> From: Ondrej Ille <ondrej.ille@...il.com>
>
> The Secondary Sample Point Source field has been
> set to an incorrect value by some mistake in the
> past
>
>   0b01 - SSP_SRC_NO_SSP - SSP is not used.
>
> for data bitrates above 1 MBit/s. The correct/default
> value already used for lower bitrates is
>
>   0b00 - SSP_SRC_MEAS_N_OFFSET - SSP position = TRV_DELAY
>          (Measured Transmitter delay) + SSP_OFFSET.
>
> The related configuration register structure is described
> in section 3.1.46 SSP_CFG of the CTU CAN FD
> IP CORE Datasheet.
>
> The analysis leading to the proper configuration
> is described in section 2.8.3 Secondary sampling point
> of the datasheet.
>
> The change has been tested on AMD/Xilinx Zynq
> with the next CTU CN FD IP core versions:
>
>  - 2.6 aka master in the "integration with Zynq-7000 system" test
>    6.12.43-rt12+ #1 SMP PREEMPT_RT kernel with CTU CAN FD git
>    driver (change already included in the driver repo)
>  - older 2.5 snapshot with mainline kernels with this patch
>    applied locally in the multiple CAN latency tester nightly runs
>    6.18.0-rc4-rt3-dut #1 SMP PREEMPT_RT
>    6.19.0-rc3-dut
>
> The logs, the datasheet and sources are available at
>
>  https://canbus.pages.fel.cvut.cz/
>
> Signed-off-by: Ondrej Ille <ondrej.ille@...il.com>
> Signed-off-by: Pavel Pisa <pisa@....cvut.cz>

While applying, re-formated patch description and added the following tags:

| Reported-by: Andrea Daoud <andreadaoud6@...il.com>
| Closes: https://lore.kernel.org/all/CAOprWotBRv_cvD3GCSe7N2tiLooZBoDisSwbu+VBAmt_2izvwQ@mail.gmail.com
| Cc: stable@...r.kernel.org
| Fixes: 2dcb8e8782d8 ("can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.")

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)