netdev - Re: [PATCH net v2 1/2] net: netdevsim: fix inconsistent carrier state after link/unlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aVvaaeoutGR0Fk7W@desktop.y-koj.net>
Date: Tue, 6 Jan 2026 00:36:09 +0900
From: Yohei Kojima <yk@...oj.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Breno Leitao <leitao@...ian.org>, Andrew Lunn <andrew@...n.ch>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] net: netdevsim: fix inconsistent carrier
 state after link/unlink

On Sun, Jan 04, 2026 at 10:54:22AM -0800, Jakub Kicinski wrote:
> On Wed, 31 Dec 2025 01:03:29 +0900 yk@...oj.net wrote:
> > +	netif_carrier_on(dev_a);
> > +	netif_carrier_on(dev_b);
> 
> 	if (netif_running(dev_a) && netif_running(dev_b)) {
> 		/// your code
> 	}
> 
> right? If one side is down there should be no carrier.

That's right. I have updated the first patch with netif_running()
checks accordingly.

Here is the v3 series including the fix:
https://lore.kernel.org/netdev/cover.1767624906.git.yk@y-koj.net/T/

Thank you,
Yohei Kojima

> -- 
> pw-bot: cr