netdev - Re: [RFC PATCH net-next v5 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aVvsq7HKOJ0RKwrA@shell.armlinux.org.uk>
Date: Mon, 5 Jan 2026 16:54:03 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Yao Zi <me@...ao.cc>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Frank <Frank.Sae@...or-comm.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
	Chen-Yu Tsai <wens@...e.org>, Jisheng Zhang <jszhang@...nel.org>,
	Furong Xu <0x1207@...il.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Mingcong Bai <jeffbai@...c.io>,
	Kexy Biscuit <kexybiscuit@...c.io>, Runhua He <hua@...c.io>,
	Xi Ruoyao <xry111@...111.site>
Subject: Re: [RFC PATCH net-next v5 2/3] net: stmmac: Add glue driver for
 Motorcomm YT6801 ethernet controller

On Thu, Dec 25, 2025 at 07:19:13AM +0000, Yao Zi wrote:
> +struct dwmac_motorcomm_priv {
> +	void __iomem *base;
> +	struct device *dev;

This is only setup in the probe function, and then only used when
reading the MAC address to print error messages - which is called
from the probe function. Would it make more sense to pass the struct
device into motorcomm_efuse_read_mac(), especially as it uses
dev_err_probe() which suggests this function can only be called from
the probe path.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!