netdev - Re: [PATCH net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iK6uqJ8YEvzcz-EsS1piyay7hTdbC=S_z-Feho9YBeN_g@mail.gmail.com>
Date: Mon, 5 Jan 2026 21:50:55 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Florian Westphal <fw@...len.de>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, syzbot+6023ea32e206eef7920a@...kaller.appspotmail.com, 
	Mazin Al Haddad <mazin@...state.dev>
Subject: Re: [PATCH net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull()

On Mon, Jan 5, 2026 at 9:40 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  5 Jan 2026 10:03:30 +0000 Eric Dumazet wrote:
> > I added skb_vlan_inet_prepare() helper in the cited commit, hinting
> > that we would need to use it more broadly.
>
> This appears to break all GRE tests, unfortunately.
> Conditions need to be inverted?

Ah sorry, I will send a fixed V2 tomorrow.