netdev - Re: [PATCH net-next v5 6/6] selftests/tc-testing: add selftests for cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875x9f58zk.fsf@toke.dk>
Date: Tue, 06 Jan 2026 11:30:23 +0100
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: Victor Nogueira <victor@...atatu.com>, Jamal Hadi Salim
 <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: Jonas Köppeler <j.koeppeler@...berlin.de>,
 cake@...ts.bufferbloat.net,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 6/6] selftests/tc-testing: add selftests for
 cake_mq qdisc

Victor Nogueira <victor@...atatu.com> writes:

> On 05/01/2026 09:50, Toke HÃ¸iland-JÃ¸rgensen wrote:
>> From: Jonas Köppeler <j.koeppeler@...berlin.de>
>> [...]
>> Test 18e0: Fail to install CAKE_MQ on single queue device
>>  [...]
>> +    {
>> +        "id": "18e0",
>> +        "name": "Fail to install CAKE_MQ on single queue device",
>> +        "category": [
>> +            "qdisc",
>> +            "cake_mq"
>> +        ],
>> +        "plugins": {
>> +            "requires": "nsPlugin"
>> +        },
>> +        "setup": [
>> +            "echo \"1 1 1\" > /sys/bus/netdevsim/new_device"
>> +        ],
>> +        "cmdUnderTest": "$TC qdisc add dev $ETH handle 1: root cake_mq",
>> +        "expExitCode": "2",
>> +        "verifyCmd": "$TC qdisc show dev $ETH",
>> +        "matchPattern": "qdisc (cake_mq 1: root|cake 0: parent 1:[1-4]) bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead 0 ",
>> +        "matchCount": "0",
>> +        "teardown": []
>
> Hi!
>
> This test is missing the device deletion on the teardown stage.

Ah, oops; will fix and respin, thanks for catching this!

-Toke