netdev - Re: [PATCH net v2] net: dlink: mask rx_coalesce/rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DFHH1YC7TYP5.NHWGAYXDE0FQ@gmail.com>
Date: Tue, 06 Jan 2026 20:32:37 +0900
From: "Yeounsu Moon" <yyyynoom@...il.com>
To: "Jakub Kicinski" <kuba@...nel.org>, "Yeounsu Moon" <yyyynoom@...il.com>
Cc: "Andrew Lunn" <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Paolo Abeni"
 <pabeni@...hat.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: dlink: mask rx_coalesce/rx_timeout before
 writing RxDMAIntCtrl

On Tue Jan 6, 2026 at 9:58 AM KST, Jakub Kicinski wrote:
> Realistically IDK if this is worth it.
>
> Paolo suggested in discussion on v1 that error checking could introduce
> a regression. If we take that concern seriously we can't change the
> (buggy) behavior at all.
>
> That said the overflow is on frames, for values > 64k and the ring is
> 256 so IDK how high values could possibly work here in the first place.
>
> Given this driver is using module params to configure coalescing I'd
> just leave this mess be. If you add ethtool configuration for
> coalescing make sure to correctly bound-check it.

Thanks for the feedback.

Understood. I'll drop this patch rather changing the current behavior.

If I add ethtool coalesce support for this driver, I'll make sure to
valid and properly bound-check the values before writing the register.

    Yeounsu Moon