netdev - Re: [PATCH RFC net-next 5/5] net: ionic: Set msi_addr_mask to IONIC_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <970e6955-d345-48e3-8ea5-83c577ecc563@amd.com>
Date: Tue, 6 Jan 2026 10:37:50 -0800
From: "Creeley, Brett" <bcreeley@....com>
To: Vivian Wang <wangruikang@...as.ac.cn>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Brett Creeley <brett.creeley@....com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: Han Gao <gaohan@...as.ac.cn>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, netdev@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH RFC net-next 5/5] net: ionic: Set msi_addr_mask to
 IONIC_ADDR_LEN-bit everywhere

On 12/23/2025 7:10 PM, Vivian Wang wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The code was originally written using no_64bit_msi, which restricts the
> device to 32-bit MSI addresses.
>
> Since msi_addr_mask is introduced, use DMA_BIT_MASK(IONIC_ADDR_LEN)
> instead of DMA_BIT_MASK(32) here for msi_addr_mask, describing the
> restriction more precisely and allowing these devices to work on
> platforms with MSI doorbell address above 32-bit space, as long as it is
> within the hardware's addressable space.
>
> Also remove #ifdef CONFIG_PPC64 wrapped around it, since this is a
> hardware restriction and not a platform one.
>
> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
>
> ---
>
> RFC because net-next is closed
>
> pensando maintainers: I don't know if this is the actual restriction,
> and do not have any Pensando device to test this. Please help with
> checking this.  Thanks.
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> index 0671deae9a28..16133537c535 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> @@ -329,10 +329,8 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>                  goto err_out;
>          }
>
> -#ifdef CONFIG_PPC64
>          /* Ensure MSI/MSI-X interrupts lie within addressable physical memory */
> -       pdev->msi_addr_mask = DMA_BIT_MASK(32);
> -#endif
> +       pdev->msi_addr_mask = DMA_BIT_MASK(IONIC_ADDR_LEN);

I'm not sure that our device has MSI address limitations. I am getting 
an answer to this locally, but we might only be limited in the DMA 
address space.

I will get back on this as quickly as possible.

Thanks,

Brett
>
>          err = ionic_setup_one(ionic);
>          if (err)
>
> --
> 2.51.2
>