netdev - Re: [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJnXg892OU13PeJMGvBKw90fJdqDaAmJ867Rptsm0zgNA@mail.gmail.com>
Date: Tue, 6 Jan 2026 20:33:40 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Florian Westphal <fw@...len.de>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, syzbot+6023ea32e206eef7920a@...kaller.appspotmail.com, 
	Mazin Al Haddad <mazin@...state.dev>
Subject: Re: [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull()

On Tue, Jan 6, 2026 at 6:56 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue,  6 Jan 2026 14:45:29 +0000 Eric Dumazet wrote:
> > v2: invert the conditions (Jakub)
>
> Thanks! Much better now, but still failing
> tools/testing/selftests/net/gre_gso.sh
>
> TAP version 13
> 1..1
> # timeout set to 3600
> # selftests: net: gre_gso.sh
> # 2.16 [+2.16]     TEST: GREv6/v4 - copy file w/ TSO                                   [ OK ]
> # 3.16 [+1.01] 2026/01/06 10:32:57 socat[20546] W exiting on signal 15
> # 3.17 [+0.01] 2026/01/06 10:32:57 socat[20546] W exiting on signal 15
> # 3.17 [+0.00]     TEST: GREv6/v4 - copy file w/ GSO                                   [FAIL]
> # 3.18 [+0.01] 2026/01/06 10:32:57 socat[20533] W exiting on signal 15
> # 3.19 [+0.00]     TEST: GREv6/v6 - copy file w/ TSO                                   [ OK ]
> # 4.19 [+1.00] 2026/01/06 10:32:59 socat[20559] W exiting on signal 15
> # 4.19 [+0.01]     TEST: GREv6/v6 - copy file w/ GSO                                   [FAIL]
> # 4.20 [+0.01] 2026/01/06 10:32:59 socat[20549] W exiting on signal 15
> # 4.22 [+0.02] 2026/01/06 10:32:59 socat[20560] W exiting on signal 15
> # 4.23 [+0.01]
> # 4.23 [+0.00] Tests passed:   2
> # 4.23 [+0.00] Tests failed:   2
> not ok 1 selftests: net: gre_gso.sh # exit=1
>
> https://netdev-ctrl.bots.linux.dev/logs/vmksft/net/results/461862/65-gre-gso-sh/stdout

For some reason I am unable to run this test from a virtme-ng instance.

I guess I wlll not make a new version of this patch, maybe Florian can
take over.