netdev - Re: [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL_Sa_ez340w2eyM_rfCnOH-UV9-zo1sYv65_hdQ-_W6g@mail.gmail.com>
Date: Tue, 6 Jan 2026 22:25:38 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Florian Westphal <fw@...len.de>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, syzbot+6023ea32e206eef7920a@...kaller.appspotmail.com, 
	Mazin Al Haddad <mazin@...state.dev>
Subject: Re: [PATCH v2 net] ip6_gre: use skb_vlan_inet_prepare() instead of pskb_inet_may_pull()

On Tue, Jan 6, 2026 at 9:31 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 6 Jan 2026 20:33:40 +0100 Eric Dumazet wrote:
> > For some reason I am unable to run this test from a virtme-ng instance.
> >
> > I guess I wlll not make a new version of this patch, maybe Florian can
> > take over.
>
> Hm, no complications seen here:
>
> $ vng -r --user root
> ..
> prompt# cd tools/testing/selftests/net/
> prompt# ./gre_gso.sh
>
>     TEST: GREv6/v4 - copy file w/ TSO                                   [ OK ]
>     TEST: GREv6/v4 - copy file w/ GSO                                   [ OK ]
> 2026/01/06 15:30:35 socat[1704] W exiting on signal 15
>     TEST: GREv6/v6 - copy file w/ TSO                                   [ OK ]
>     TEST: GREv6/v6 - copy file w/ GSO                                   [ OK ]
> 2026/01/06 15:30:35 socat[1721] W exiting on signal 15
>
> Tests passed:   4
> Tests failed:   0
>
>
> Happy to give you access to the netdev machine to experiment there
> if that helps, just send me an SSH key.

My vng launch script had the -v option ( --verbose, -v   Increase
console output verbosity), and this was causing issues.


Anyway, using my v2 patch on top of current net-tree
(238e03d0466239410) seems fine to me, no error at all,
not sure why your bot is unhappy.

Could multiple patches have been tested together, one having a side effect ?

[hi on] edumazet@...mazet1:~/git/net-next$ vng  -r --user root --cpus
4 --memory 4G
/usr/lib/tmpfiles.d/legacy.conf:14: Duplicate line for path
"/run/lock", ignoring.
          _      _
   __   _(_)_ __| |_ _ __ ___   ___       _ __   __ _
   \ \ / / |  __| __|  _   _ \ / _ \_____|  _ \ / _  |
    \ V /| | |  | |_| | | | | |  __/_____| | | | (_| |
     \_/ |_|_|   \__|_| |_| |_|\___|     |_| |_|\__  |
                                                |___/
   kernel version: 6.16.12-1rodete2-amd64 x86_64
   (CTRL+d to exit)

Illegal instruction        shell-history-configtool configure-interactively
root@...tme-ng:/usr/local/google/home/edumazet/git/net-next# cd
tools/testing/selftests/net/
root@...tme-ng:/usr/local/google/home/edumazet/git/net-next/tools/testing/selftests/net#
./gre_gso.sh
    TEST: GREv6/v4 - copy file w/ TSO                                   [ OK ]
    TEST: GREv6/v4 - copy file w/ GSO                                   [ OK ]
2026/01/06 21:25:27 socat[1214] W exiting on signal 15
    TEST: GREv6/v6 - copy file w/ TSO                                   [ OK ]
    TEST: GREv6/v6 - copy file w/ GSO                                   [ OK ]
2026/01/06 21:25:27 socat[1229] W exiting on signal 15

Tests passed:   4
Tests failed:   0
root@...tme-ng:/usr/local/google/home/edumazet/git/net-next/tools/testing/selftests/net#