netdev - Re: [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and serialize queue resets per port.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260106225950.GA11626@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Tue, 6 Jan 2026 14:59:50 -0800
From: Dipayaan Roy <dipayanroy@...ux.microsoft.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, longli@...rosoft.com,
	kotaranov@...rosoft.com, horms@...nel.org,
	shradhagupta@...ux.microsoft.com, ssengar@...ux.microsoft.com,
	ernis@...ux.microsoft.com, shirazsaleem@...rosoft.com,
	linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
	dipayanroy@...rosoft.com
Subject: Re: [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and
 serialize queue resets per port.

On Mon, Jan 05, 2026 at 05:30:56PM -0800, Jakub Kicinski wrote:
> On Fri, 2 Jan 2026 20:57:05 -0800 Dipayaan Roy wrote:
> > +		apc = netdev_priv(ndev);
> > +		disable_work_sync(&apc->queue_reset_work.work);
> 
> AI code review points out:
> 
>   In mana_remove(), disable_work_sync() is called for each port's
>   queue_reset_work. However, when resuming=true, mana_probe() creates a new
>   workqueue but does not call mana_probe_port() (which contains INIT_WORK),
>   and there is no enable_work() call for queue_reset_work in the resume path.
> 
>   The existing link_change_work handles this correctly: it is disabled in
>   mana_remove() and re-enabled with enable_work(&ac->link_change_work) in
>   mana_probe() when resuming=true.
> 
>   Should enable_work(&apc->queue_reset_work.work) be called for each port in
>   the resuming path of mana_probe(), similar to how link_change_work is
>   handled? Otherwise TX timeout recovery appears to remain disabled after a
>   suspend/resume cycle.
> -- 
> pw-bot: cr

Thanks Jakub for pointing this out. I will send out a new version.

Regards
Dipayaan Roy