[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <297860d547bb93b794e7b1cee4eb7b93b9e05e9d.camel@gmail.com>
Date: Wed, 07 Jan 2026 15:59:17 +0100
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: forwarding: update PTP tcpdump
patterns
Hi Jakub,
On Wed, 2026-01-07 at 06:53 -0800, Jakub Kicinski wrote:
> Recent version of tcpdump (tcpdump-4.99.6-1.fc43.x86_64) seems to have
> removed the spurious space after msg type in PTP info, e.g.:
>
> before: PTPv2, majorSdoId: 0x0, msg type : sync msg, length: 44
> after: PTPv2, majorSdoId: 0x0, msg type: sync msg, length: 44
>
> Update our patterns to match both.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> ---
> CC: shuah@...nel.org
> CC: vladimir.oltean@....com
> CC: alexander.sverdlin@...il.com
> CC: linux-kselftest@...r.kernel.org
> ---
> .../net/forwarding/local_termination.sh | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
> index 892895659c7e..1f2bf6e81847 100755
> --- a/tools/testing/selftests/net/forwarding/local_termination.sh
> +++ b/tools/testing/selftests/net/forwarding/local_termination.sh
> @@ -306,39 +306,39 @@ run_test()
>
> if [ $skip_ptp = false ]; then
> check_rcv $rcv_if_name "1588v2 over L2 transport, Sync" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : sync msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over L2 transport, Follow-Up" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : follow up msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over L2 transport, Peer Delay Request" \
> - "ethertype PTP (0x88f7).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype PTP (0x88f7).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Sync" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : sync msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Follow-Up" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : follow up msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv4, Peer Delay Request" \
> - "ethertype IPv4 (0x0800).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype IPv4 (0x0800).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Sync" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : sync msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: sync msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Follow-Up" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : follow up msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: follow up msg" \
> true "$test_name"
>
> check_rcv $rcv_if_name "1588v2 over IPv6, Peer Delay Request" \
> - "ethertype IPv6 (0x86dd).* PTPv2.* msg type : peer delay req msg" \
> + "ethertype IPv6 (0x86dd).* PTPv2.* msg type *: peer delay req msg" \
> true "$test_name"
> fi
>
--
Alexander Sverdlin.
Powered by blists - more mailing lists