netdev - Re: [PATCH 3/5] drm/radeon: Raise msi_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15ec03f3-f0cf-45f7-b7f6-98b075533d3e@amd.com>
Date: Wed, 7 Jan 2026 16:20:25 +0100
From: Christian König <christian.koenig@....com>
To: Vivian Wang <wangruikang@...as.ac.cn>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>,
 Alex Deucher <alexander.deucher@....com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Brett Creeley <brett.creeley@....com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: Han Gao <gaohan@...as.ac.cn>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, netdev@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH 3/5] drm/radeon: Raise msi_addr_mask to 40 bits for
 pre-Bonaire

On 12/24/25 04:10, Vivian Wang wrote:
> The code was originally written using no_64bit_msi, which restricts the
> device to 32-bit MSI addresses.
> 
> Since msi_addr_mask is introduced, use DMA_BIT_MASK(40) instead of
> DMA_BIT_MASK(32) here for msi_addr_mask, describing the restriction more
> precisely and allowing these devices to work on platforms with MSI
> doorbell address above 32-bit space, as long as it is within the
> hardware restriction of 40-bit space.
> 
> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
> ---
>  drivers/gpu/drm/radeon/radeon_irq_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> index d550554a6f3f..ea519d43348b 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> @@ -251,8 +251,8 @@ static bool radeon_msi_ok(struct radeon_device *rdev)
>  	 * IBM POWER servers, so we limit them
>  	 */
>  	if (rdev->family < CHIP_BONAIRE) {
> -		dev_info(rdev->dev, "radeon: MSI limited to 32-bit\n");
> -		rdev->pdev->msi_addr_mask = DMA_BIT_MASK(32);
> +		dev_info(rdev->dev, "radeon: MSI limited to 40-bit\n");
> +		rdev->pdev->msi_addr_mask = DMA_BIT_MASK(40);

Well, that is not even remotely correct.

Please move that close to the dma_set_mask_and_coherent() call in radeon_device_init() (file radeon_device.c).

The check there is most likely already what you need. Should be pretty straight forward.

Regards,
Christian.

>  	}
>  
>  	/* force MSI on */
>