netdev - Re: [PATCH 04/15] net: ftgmac100: Use devm_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107155517.GC345651@kernel.org>
Date: Wed, 7 Jan 2026 15:55:17 +0000
From: Simon Horman <horms@...nel.org>
To: Jacky Chou <jacky_chou@...eedtech.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH 04/15] net: ftgmac100: Use devm_alloc_etherdev()

On Mon, Jan 05, 2026 at 03:08:50PM +0800, Jacky Chou wrote:
> From: Andrew Lunn <andrew@...n.ch>
> 
> Make use of devm_alloc_etherdev() to simplify cleanup.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index f07167cabf39..75c7ab43e7e9 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1877,10 +1877,9 @@ static int ftgmac100_probe(struct platform_device *pdev)
>  		return irq;
>  
>  	/* setup net_device */
> -	netdev = alloc_etherdev(sizeof(*priv));
> +	netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
>  	if (!netdev) {
> -		err = -ENOMEM;
> -		goto err_alloc_etherdev;
> +		return -ENOMEM;
>  	}

nit: There is no longer any need for {} here.

...