netdev - Re: [PATCH net-next v1 13/13] tools: ynl-gen-c: Fix remaining pylint warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107084534.11dcb921@kernel.org>
Date: Wed, 7 Jan 2026 08:45:34 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, "Matthieu Baerts (NGI0)" <matttbe@...nel.org>, Gal
 Pressman <gal@...dia.com>, Jan Stancek <jstancek@...hat.com>, Hangbin Liu
 <liuhangbin@...il.com>, Nimrod Oren <noren@...dia.com>,
 netdev@...r.kernel.org, Jonathan Corbet <corbet@....net>, Asbjørn Sloth Tønnesen <ast@...erby.net>,
 Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Jacob Keller
 <jacob.e.keller@...el.com>, Ruben Wauters <rubenru09@....com>,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v1 13/13] tools: ynl-gen-c: Fix remaining
 pylint warnings

On Wed,  7 Jan 2026 12:21:43 +0000 Donald Hunter wrote:
> -                     'return ynl_submsg_failed(yarg, "%s", "%s");' %
> -                        (self.name, self['selector']),
> -                    f"if ({self.nested_render_name}_parse(&parg, {sel_var}, attr))",
> +                     f'return ynl_submsg_failed(yarg, "{self.name}", "{self['selector']}");',
> +                     f"if ({self.nested_render_name}_parse(&parg, {sel_var}, attr))",

This one breaks build of tools/ with old Python, unfortunately:

  File "/home/virtme/testing/wt-24/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 946
    f'return ynl_submsg_failed(yarg, "{self.name}", "{self['selector']}");',
                                                            ^
SyntaxError: f-string: unmatched '['
make[2]: *** [Makefile:48: psp-user.c] Error 1
make[1]: *** [Makefile:28: generated] Error 2
make: *** [../../net/ynl.mk:31: /home/virtme/testing/wt-24/tools/testing/selftests/drivers/net/libynl.a] Error 2
-- 
pw-bot: cr