netdev - Re: [PATCH net-next v15 05/12] virtio_net: Query and set flow filter caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17453401-86b8-4fbc-8907-c2cf1faa06ac@nvidia.com>
Date: Wed, 7 Jan 2026 16:09:01 -0600
From: Dan Jurgens <danielj@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
 pabeni@...hat.com, virtualization@...ts.linux.dev, parav@...dia.com,
 shshitrit@...dia.com, yohadt@...dia.com, xuanzhuo@...ux.alibaba.com,
 eperezma@...hat.com, jgg@...pe.ca, kevin.tian@...el.com,
 andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [PATCH net-next v15 05/12] virtio_net: Query and set flow filter
 caps

On 1/7/26 3:37 PM, Jakub Kicinski wrote:
> On Wed, 7 Jan 2026 11:04:15 -0600 Daniel Jurgens wrote:
>> +	if (err && err != -EOPNOTSUPP) {
>> +		if (netif_running(vi->dev))
>> +			virtnet_close(vi->dev);
>> +
>> +		/* disable_rx_mmode_work takes the rtnl_lock, so just set the
>> +		 * flag here while holding the lock.
>> +		 *
>> +		 * remove_vq_common resets the device and frees the vqs.
>> +		 */
>> +		vi->rx_mode_work_enabled = false;
>> +		disable_delayed_refill(vi);
>> +		rtnl_unlock();
>> +		remove_vq_common(vi);
>> +		return err;
> 
> disable_delayed_refill() is going away in net 
> 
> https://lore.kernel.org/all/20260106150438.7425-1-minhquangbui99@gmail.com/
> 
> You'll have to wait for that change to propagate to net-next to avoid
> a transient build issue:
> 
> https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2026-01-07--21-00&pw-n=0&pass=0

Thanks for the heads up. The AI bot flagged another bug with the return
value of virtnet_restore_up so I'll send a v16 once this patch comes in.