netdev - Re: [PATCH net-next] ethtool: Clarify len/n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260106174816.0476e043@kernel.org>
Date: Tue, 6 Jan 2026 17:48:16 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>, Paolo Abeni <pabeni@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>, Simon Horman
 <horms@...nel.org>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next] ethtool: Clarify len/n_stats fields in/out
 semantics

On Mon, 5 Jan 2026 18:39:23 +0200 Gal Pressman wrote:
> - * @n_stats: On return, the number of statistics
> + * @n_stats: On entry, the number of stats requested.
> +	On return, the number of stats returned.
>   * @data: Array of statistics

Missing a '*'
But stepping back we should rephrase the comment to cover both
directions instead of mechanically adding the corresponding "On entry"

FTR my recollection was that we never validated these field on entry and
if that's the case 7b07be1ff1cb6 is quite questionable, uAPI-breakage
wise.
-- 
pw-bot: cr