netdev - Re: [PATCH net-next 4/6] bnxt_en: Defrag the NVRAM region when resizing UPDATE region fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260106181926.4d561295@kernel.org>
Date: Tue, 6 Jan 2026 18:19:26 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
 andrew.gospodarek@...adcom.com, Somnath Kotur <somnath.kotur@...adcom.com>,
 Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [PATCH net-next 4/6] bnxt_en: Defrag the NVRAM region when
 resizing UPDATE region fails

On Mon,  5 Jan 2026 13:58:31 -0800 Michael Chan wrote:
> +			if (rc == -ENOSPC) {
> +				if (retry || bnxt_hwrm_nvm_defrag(bp))
> +					break;
> +				retry = true;
> +			}
> +		} while (rc == -ENOSPC && retry);

Since there's an explicit break under rc == ENOSPC + retry
the while loop doesn't need to check retry.
Something needs to be cleaned up here