[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<SEYPR06MB5134F69965192166B1C631259D85A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Thu, 8 Jan 2026 01:31:02 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Simon Horman <horms@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>
Subject: [PATCH 04/15] net: ftgmac100: Use devm_alloc_etherdev()
> > /* setup net_device */
> > - netdev = alloc_etherdev(sizeof(*priv));
> > + netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
> > if (!netdev) {
> > - err = -ENOMEM;
> > - goto err_alloc_etherdev;
> > + return -ENOMEM;
> > }
>
> nit: There is no longer any need for {} here.
>
Thank you for your reply.
Agreed. After modification,
it becomes a single-run code, no need for curly braces {}.
I will remove it in next version.
Thanks,
Jacky
Powered by blists - more mailing lists