netdev - Re: [PATCH iproute2-next v3] lib/bpf_legacy: Use userspace SHA-1 code instead of AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5sw2js6.fsf@toke.dk>
Date: Thu, 08 Jan 2026 16:42:17 +0100
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: David Ahern <dsahern@...nel.org>, Eric Biggers <ebiggers@...nel.org>,
 Stephen Hemminger <stephen@...workplumber.org>, netdev@...r.kernel.org
Cc: bpf@...r.kernel.org, linux-crypto@...r.kernel.org, Ard Biesheuvel
 <ardb@...nel.org>, Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH iproute2-next v3] lib/bpf_legacy: Use userspace SHA-1
 code instead of AF_ALG

David Ahern <dsahern@...nel.org> writes:

> On 12/18/25 1:09 PM, Eric Biggers wrote:
>> diff --git a/include/sha1.h b/include/sha1.h
>> new file mode 100644
>> index 00000000..4a2ed513
>> --- /dev/null
>> +++ b/include/sha1.h
>> @@ -0,0 +1,18 @@
>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>> +/*
>> + * SHA-1 message digest algorithm
>> + *
>> + * Copyright 2025 Google LLC
>> + */
>> +#ifndef __SHA1_H__
>> +#define __SHA1_H__
>> +
>> +#include <linux/types.h>
>> +#include <stddef.h>
>> +
>> +#define SHA1_DIGEST_SIZE 20
>> +#define SHA1_BLOCK_SIZE 64
>
> How come these are not part of the uapi?
>
> I applied this to iproute2-next to get as much soak time as possible.
> Anyone using legacy bpf (added Toke in case he knows) in particular
> should test with top of tree.

Hmm, not aware of any users of the old code. I believe most distros
build iproute2 with libbpf support these days; that's certainly the case
in Red Hat land.

-Toke