netdev - Re: [PATCH net-next] selftests: tls: avoid flakiness in data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aV_Qkmfo6VPCN_gt@krikkit>
Date: Thu, 8 Jan 2026 16:43:14 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: tls: avoid flakiness in data_steal

2026-01-06, 12:02:05 -0800, Jakub Kicinski wrote:
> We see the following failure a few times a week:
> 
>   #  RUN           global.data_steal ...
>   # tls.c:3280:data_steal:Expected recv(cfd, buf2, sizeof(buf2), MSG_DONTWAIT) (10000) == -1 (-1)
>   # data_steal: Test failed
>   #          FAIL  global.data_steal
>   not ok 8 global.data_steal
> 
> The 10000 bytes read suggests that the child process did a recv()
> of half of the data using the TLS ULP and we're now getting the
> remaining half. The intent of the test is to get the child to
> enter _TCP_ recvmsg handler, so it needs to enter the syscall before
> parent installed the TLS recvmsg with setsockopt(SOL_TLS).
> 
> Instead of the 10msec sleep send 1 byte of data and wait for the
> child to consume it.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: sd@...asysnail.net
> CC: shuah@...nel.org
> CC: linux-kselftest@...r.kernel.org
> ---
>  tools/testing/selftests/net/tls.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

-- 
Sabrina