netdev - Re: [PATCH v2] net: ethernet: mtk_eth_soc: avoid writing to ESW registers on MT7628

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260108083530.6169b627@kernel.org>
Date: Thu, 8 Jan 2026 08:35:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: Joris Vaisvila <joey@...yisr.com>, netdev@...r.kernel.org, nbd@....name,
 sean.wang@...iatek.com, lorenzo@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH v2] net: ethernet: mtk_eth_soc: avoid writing to ESW
 registers on MT7628

On Thu, 8 Jan 2026 15:04:57 +0000 Simon Horman wrote:
> On Tue, Jan 06, 2026 at 07:18:28AM +0200, Joris Vaisvila wrote:
> > The MT7628 does not expose MAC control registers. Writes to these
> > registers corrupt the ESW VLAN configuration. Existing drivers
> > never use the affected features, so this went unnoticed.
> > 
> > This patch skips MCR register reads and writes on MT7628, preventing
> > invalid register access.
> > 
> > Fixes: 296c9120752b ("net: ethernet: mediatek: Add MT7628/88 SoC support")
> > Signed-off-by: Joris Vaisvila <joey@...yisr.com>
> 
> While I think a minimal patch along these lines is appropriate as a bug
> fix. I am wondering if, as a follow-up, consideration could be given to
> registering alternate phy ops for MT7628. This would push the conditional
> handling to probe rather than calback execution time. And I suspect it
> would lead to a cleaner implementation.

Plus the commit message says: "Existing drivers never use the affected
features, so this went unnoticed." which makes it sound like user will
not notice the bad writes today?

So perhaps we can go for the cleaner approach and stick to net-next
(without fixing the older kernels?). Sorry for not reading the commit
message closely enough on v1.