netdev - RE: [Intel-wired-lan] [Patch net v2] ice: Fix incorrect timeout ice_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241AEE4989336C3583AE3698B82A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Fri, 9 Jan 2026 09:08:03 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: "Ding, Hui" <dinghui@...gfor.com.cn>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Ding, Hui"
	<dinghui@...gfor.com.cn>
Subject: RE: [Intel-wired-lan] [Patch net v2] ice: Fix incorrect timeout
 ice_release_res()

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ding Hui
> Sent: 06 December 2025 19:16
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; Keller, Jacob E <jacob.e.keller@...el.com>; intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Ding, Hui <dinghui@...gfor.com.cn>
> Subject: [Intel-wired-lan] [Patch net v2] ice: Fix incorrect timeout ice_release_res()
>
> The commit 5f6df173f92e ("ice: implement and use rd32_poll_timeout for ice_sq_done timeout") converted ICE_CTL_Q_SQ_CMD_TIMEOUT from jiffies to microseconds.
>
> But the ice_release_res() function was missed, and its logic still treats ICE_CTL_Q_SQ_CMD_TIMEOUT as a jiffies value.
>
> So correct the issue by usecs_to_jiffies().
>
> Found by inspection of the DDP downloading process.
> Compile and modprobe tested only.
>
> Fixes: 5f6df173f92e ("ice: implement and use rd32_poll_timeout for ice_sq_done timeout")
> Signed-off-by: Ding Hui <dinghui@...gfor.com.cn>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ---
> v1->v2: rebase to net branch and add commit log.
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)