netdev - Re: [PATCH v5.10.y] bpf, sockmap: Don't let sock_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADOamyvTXyyg51_Pc1mjJRJsyAY9vb3GOLZ6XsGt7p0c84VskA@mail.gmail.com>
Date: Fri, 9 Jan 2026 16:40:27 +0530
From: Harinadh Dommaraju <harinadh.dommaraju@...adcom.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, john.fastabend@...il.com, daniel@...earbox.net, 
	jakub@...udflare.com, lmb@...udflare.com, davem@...emloft.net, 
	kuba@...nel.org, ast@...nel.org, andrii@...nel.org, kafai@...com, 
	songliubraving@...com, yhs@...com, kpsingh@...nel.org, netdev@...r.kernel.org, 
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org, ajay.kaher@...adcom.com, 
	alexey.makhalov@...adcom.com, vamsi-krishna.brahmajosyula@...adcom.com, 
	yin.ding@...adcom.com, tapas.kundu@...adcom.com, 
	Eric Dumazet <edumazet@...gle.com>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH v5.10.y] bpf, sockmap: Don't let sock_map_{close,destroy,unhash}
 call itself

On Thu, Jan 8, 2026 at 9:24 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, Dec 12, 2025 at 03:54:58AM +0000, HarinadhD wrote:
> > From: Jakub Sitnicki <jakub@...udflare.com>
> >
> > [ Upstream commit 5b4a79ba65a1ab479903fff2e604865d229b70a9 ]
> >
> > sock_map proto callbacks should never call themselves by design. Protect
> > against bugs like [1] and break out of the recursive loop to avoid a stack
> > overflow in favor of a resource leak.
> >
> > [1] https://lore.kernel.org/all/00000000000073b14905ef2e7401@google.com/
> >
> > Suggested-by: Eric Dumazet <edumazet@...gle.com>
> > Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> > Acked-by: John Fastabend <john.fastabend@...il.com>
> > Link: https://lore.kernel.org/r/20230113-sockmap-fix-v2-1-1e0ee7ac2f90@cloudflare.com
> > Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > [ Harinadh: Modified to apply on v5.10.y ]
> > Signed-off-by: HarinadhD <Harinadh.Dommaraju@...adcom.com>
>
> Please use your name for your signed-off-by.
>

Thanks Greg.
I have sent v2.

- Harinadh

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5438 bytes)