netdev - Re: [PATCH net-next] xgbe: Use netlink extack to report errors to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260109062521.625088cc@kernel.org>
Date: Fri, 9 Jan 2026 06:25:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: <netdev@...r.kernel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
 <davem@...emloft.net>, <andrew+netdev@...n.ch>, <Shyam-sundar.S-k@....com>,
 Vishal Badole <Vishal.Badole@....com>
Subject: Re: [PATCH net-next] xgbe: Use netlink extack to report errors to
 ethtool

On Fri, 9 Jan 2026 13:17:46 +0530 Raju Rangoju wrote:
>  	if (ringparam->rx_mini_pending || ringparam->rx_jumbo_pending) {
> -		netdev_err(netdev, "unsupported ring parameter\n");
> +		NL_SET_ERR_MSG_FMT_MOD(extack, "unsupported ring parameter\n");
>  		return -EINVAL;
>  	}

There should be no \n at the end of the extack string.
Please don't use _FMT if there's no formatting going on.
-- 
pw-bot: cr