netdev - Re: [net-next,v7,4/6] net/sched: sch_cake: Share config across cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109041214.2918115-1-kuba@kernel.org>
Date: Thu,  8 Jan 2026 20:12:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: toke@...hat.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	jiri@...nulli.us,
	cake@...ts.bufferbloat.net,
	toke@...e.dk,
	j.koeppeler@...berlin.de,
	willemb@...gle.com,
	xiyou.wangcong@...il.com,
	horms@...nel.org,
	pabeni@...hat.com,
	jhs@...atatu.com,
	davem@...emloft.net,
	netdev@...r.kernel.org,
	edumazet@...gle.com,
	victor@...atatu.com
Subject: Re: [net-next,v7,4/6] net/sched: sch_cake: Share config across cake_mq sub-qdiscs

This is an AI-generated review of your patch.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net/sched: sch_cake: Share config across cake_mq sub-qdiscs

This commit adds support for configuring the cake_mq instance directly,
sharing the config across the cake sub-qdiscs.

> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
> index deb9f411db98..4dbfee3e6207 100644
> --- a/net/sched/sch_cake.c
> +++ b/net/sched/sch_cake.c

[ ... ]

> +	if (tb[TCA_CAKE_AUTORATE]) {
> +		if (!!nla_get_u32(tb[TCA_CAKE_AUTORATE])) {
> +			if (q->is_shared) {
> +				NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT],
                                                         ^^^^^^^^^^^^^^
Should this be tb[TCA_CAKE_AUTORATE] instead of tb[TCA_CAKE_NAT]? The
check here is for TCA_CAKE_AUTORATE, but the error message attribute
points to TCA_CAKE_NAT. This appears to be a copy-paste from the NAT
handling code just above. When a user enables autorate-ingress on
cake_mq, the error will reference the wrong netlink attribute.

> +						    "Can't use autorate-ingress with cake_mq");
> +				return -EOPNOTSUPP;
> +			}
> +			rate_flags |= CAKE_FLAG_AUTORATE_INGRESS;
> +		} else {
> +			rate_flags &= ~CAKE_FLAG_AUTORATE_INGRESS;
> +		}
> +	}

[ ... ]
-- 
pw-bot: cr