netdev - Re: [PATCH net-next v2 0/2] r8169: add support for RTL8127ATF (10G Fiber SFP)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6df422fa-5d65-435f-896b-6495c63eaacf@gmail.com>
Date: Sat, 10 Jan 2026 21:03:05 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>, Vladimir Oltean
 <vladimir.oltean@....com>, Michael Klein <michael@...sekall.de>,
 Daniel Golle <daniel@...rotopia.org>,
 Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Aleksander Jan Bajkowski <olek2@...pl>,
 Fabio Baltieri <fabio.baltieri@...il.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/2] r8169: add support for RTL8127ATF (10G
 Fiber SFP)

On 1/10/2026 7:48 PM, Jakub Kicinski wrote:
> On Sat, 10 Jan 2026 16:12:30 +0100 Heiner Kallweit wrote:
>> RTL8127ATF supports a SFP+ port for fiber modules (10GBASE-SR/LR/ER/ZR and
>> DAC). The list of supported modes was provided by Realtek. According to the
>> r8127 vendor driver also 1G modules are supported, but this needs some more
>> complexity in the driver, and only 10G mode has been tested so far.
>> Therefore mainline support will be limited to 10G for now.
>> The SFP port signals are hidden in the chip IP and driven by firmware.
>> Therefore mainline SFP support can't be used here.
>> The PHY driver is used by the RTL8127ATF support in r8169.
>> RTL8127ATF reports the same PHY ID as the TP version. Therefore use a dummy
>> PHY ID.
> 
> Hi Heiner!
> 
> This series silently conflicts with Daniel's changes. I wasn't clear
> whether the conclusion here:
> https://lore.kernel.org/all/1261b3d5-3e09-4dd6-8645-fd546cbdce62@gmail.com/
> is that we shouldn't remove the define or Daniel's changes are good 
> to go in.. Could y'all spell out for me what you expect?

I'm fine with replacing RTL_VND2_PHYSR with RTL_PHYSR, as proposed by Daniel.
However, as this isn't a fully trivial change, I'd like to avoid this change
in my series, and leave it to Daniel's series. Means he would have to add
the conversion of the call I just add.
Which series to apply first depends on whether Daniel has to send a new version,
or whether it's fine as-is. There was a number of comments, therefore I'm not
100% sure.