netdev - Re: [PATCH net-next v2 0/2] net: phy: fixed_phy: replace list of fixed PHYs with static array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a34af80-df77-4b3a-8394-c1b768da6ebd@bootlin.com>
Date: Mon, 12 Jan 2026 11:36:25 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 0/2] net: phy: fixed_phy: replace list of
 fixed PHYs with static array

Hello Heiner,

On 11/01/2026 13:40, Heiner Kallweit wrote:
> Due to max 32 PHY addresses being available per mii bus, using a list
> can't support more fixed PHY's. And there's no known use case for as
> much as 32 fixed PHY's on a system. 8 should be plenty of fixed PHY's,
> so use an array of that size instead of a list. This allows to
> significantly reduce the code size and complexity.
> In addition replace heavy-weight IDA with a simple bitmap.
> 
> Heiner Kallweit (2):
>   net: phy: fixed_phy: replace list of fixed PHYs with static array
>   net: phy: fixed_phy: replace IDA with a bitmap
> 
>  drivers/net/phy/fixed_phy.c | 83 +++++++++++++------------------------
>  1 file changed, 29 insertions(+), 54 deletions(-)
> 

I've tested this on a few boards that use fixed-link (A turris omnia, a
custom board with ksz9477), and the code LGTM :) I think 8 fixed-phy is
good for now, and the way you implemented that makes it trivial to
change that if need be.

For the series,

Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime