netdev - Re: [PATCH net-next v2 3/6] selftests: drv-net: gro: use cmd print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h5sr3ylw.fsf@nvidia.com>
Date: Mon, 12 Jan 2026 11:37:56 +0100
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<shuah@...nel.org>, <linux-kselftest@...r.kernel.org>, <sdf@...ichev.me>,
	<willemb@...gle.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next v2 3/6] selftests: drv-net: gro: use cmd print


Jakub Kicinski <kuba@...nel.org> writes:

> Now that cmd() can be printed directly remove the old formatting.
>
> Before:
>
>   # fragmented ip6 doesn't coalesce:
>   # Expected {200 100 100 }, Total 3 packets
>   # Received {200 100 }, Total 2 packets.
>   # /root/ksft-net-drv/drivers/net/gro: incorrect number of packets
>
> Now:
>
>   # CMD: drivers/net/gro --ipv6 --dmac 9e:[...]
>   #   EXIT: 1
>   #   STDOUT: fragmented ip6 doesn't coalesce:
>   #   STDERR: Expected {200 100 100 }, Total 3 packets
>   #           Received {200 100 }, Total 2 packets.
>   #           /root/ksft-net-drv/drivers/net/gro: incorrect number of packets
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Petr Machata <petrm@...dia.com>