netdev - RE: [Intel-wired-lan] [PATCH net-next 08/10] veth: Call skb_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89864D82F9F845871E9D12ADE581A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 12 Jan 2026 11:33:10 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Jakub Sitnicki <jakub@...udflare.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Michael Chan
	<michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Saeed Mahameed <saeedm@...dia.com>, "Leon
 Romanovsky" <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, Mark Bloch
	<mbloch@...dia.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, "John
 Fastabend" <john.fastabend@...il.com>, Stanislav Fomichev <sdf@...ichev.me>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "kernel-team@...udflare.com"
	<kernel-team@...udflare.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next 08/10] veth: Call
 skb_metadata_set when skb->data points past metadata



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Jakub Sitnicki via Intel-wired-lan
> Sent: Saturday, January 10, 2026 10:05 PM
> To: netdev@...r.kernel.org
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Simon Horman <horms@...nel.org>; Michael Chan
> <michael.chan@...adcom.com>; Pavan Chebbi <pavan.chebbi@...adcom.com>;
> Andrew Lunn <andrew+netdev@...n.ch>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Saeed Mahameed <saeedm@...dia.com>;
> Leon Romanovsky <leon@...nel.org>; Tariq Toukan <tariqt@...dia.com>;
> Mark Bloch <mbloch@...dia.com>; Alexei Starovoitov <ast@...nel.org>;
> Daniel Borkmann <daniel@...earbox.net>; Jesper Dangaard Brouer
> <hawk@...nel.org>; John Fastabend <john.fastabend@...il.com>;
> Stanislav Fomichev <sdf@...ichev.me>; intel-wired-
> lan@...ts.osuosl.org; bpf@...r.kernel.org; kernel-team@...udflare.com
> Subject: [Intel-wired-lan] [PATCH net-next 08/10] veth: Call
> skb_metadata_set when skb->data points past metadata
> 
> Prepare to copy the XDP metadata into an skb extension in
> skb_metadata_set.
> 
> Unlike other drivers, veth calls skb_metadata_set after
> eth_type_trans, which pulls the Ethernet header and moves skb->data.
> This violates the new contract with skb_metadata.
> 
> Adjust the driver to pull the MAC header after calling
> skb_metadata_set.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---
>  drivers/net/veth.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c index
> 14e6f2a2fb77..1d1dbfa2e5ef 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -874,11 +874,11 @@ static struct sk_buff *veth_xdp_rcv_skb(struct
> veth_rq *rq,
>  	else
>  		skb->data_len = 0;
> 
> -	skb->protocol = eth_type_trans(skb, rq->dev);
> -
>  	metalen = xdp->data - xdp->data_meta;
>  	if (metalen)
>  		skb_metadata_set(skb, metalen);
> +
> +	skb->protocol = eth_type_trans(skb, rq->dev);
>  out:
>  	return skb;
>  drop:
> 
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>