netdev - RE: [PATCH net-next] net: hv_netvsc: reject RSS hash key programming without RX indirection table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA3PR21MB3867F67C949B42DF5984A71CCA81A@SA3PR21MB3867.namprd21.prod.outlook.com>
Date: Mon, 12 Jan 2026 15:34:59 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Aditya Garg <gargaditya@...ux.microsoft.com>, KY Srinivasan
	<kys@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui
	<DECUI@...rosoft.com>, Long Li <longli@...rosoft.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dipayanroy@...ux.microsoft.com" <dipayanroy@...ux.microsoft.com>,
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>,
	"shradhagupta@...ux.microsoft.com" <shradhagupta@...ux.microsoft.com>,
	"ernis@...ux.microsoft.com" <ernis@...ux.microsoft.com>, Aditya Garg
	<gargaditya@...rosoft.com>
Subject: RE: [PATCH net-next] net: hv_netvsc: reject RSS hash key programming
 without RX indirection table



> -----Original Message-----
> From: Aditya Garg <gargaditya@...ux.microsoft.com>
> Sent: Monday, January 12, 2026 5:02 AM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> <DECUI@...rosoft.com>; Long Li <longli@...rosoft.com>;
> andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; stephen@...workplumber.org; linux-
> hyperv@...r.kernel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; dipayanroy@...ux.microsoft.com;
> ssengar@...ux.microsoft.com; shradhagupta@...ux.microsoft.com;
> ernis@...ux.microsoft.com; Aditya Garg <gargaditya@...rosoft.com>;
> gargaditya@...ux.microsoft.com
> Subject: [PATCH net-next] net: hv_netvsc: reject RSS hash key programming
> without RX indirection table
> 
> RSS configuration requires a valid RX indirection table. When the device
> reports a single receive queue, rndis_filter_device_add() does not
> allocate an indirection table, accepting RSS hash key updates in this
> state leads to a hang.
> 
> Fix this by gating netvsc_set_rxfh() on ndc->rx_table_sz and return
> -EOPNOTSUPP when the table is absent. This aligns set_rxfh with the device
> capabilities and prevents incorrect behavior.
> 
> Fixes: 962f3fee83a4 ("netvsc: add ethtool ops to get/set RSS key")
> Signed-off-by: Aditya Garg <gargaditya@...ux.microsoft.com>
> Reviewed-by: Dipayaan Roy <dipayanroy@...ux.microsoft.com>

Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>