netdev - Re: [PATCH] net: octeon_ep_vf: fix free_irq dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWVSCMuX04gdLPL-@horms.kernel.org>
Date: Mon, 12 Jan 2026 19:56:56 +0000
From: Simon Horman <horms@...nel.org>
To: Kery Qi <qikeyu2017@...il.com>
Cc: vburru@...vell.com, netdev@...r.kernel.org, srasheed@...vell.com,
	pabeni@...hat.com, sedara@...vell.com, andrew+netdev@...n.ch,
	sburla@...vell.com, kuba@...nel.org, edumazet@...gle.com
Subject: Re: [PATCH] net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ
 rollback

+ Maintainers

On Fri, Jan 09, 2026 at 12:42:57AM +0800, Kery Qi wrote:
> octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
> ioq_vector. If request_irq() fails part-way, the rollback loop calls
> free_irq() with dev_id set to 'oct', which does not match the original
> dev_id and may leave the irqaction registered.
> 
> This can keep IRQ handlers alive while ioq_vector is later freed during
> unwind/teardown, leading to a use-after-free or crash when an interrupt
> fires.
> 
> Fix the error path to free IRQs with the same ioq_vector dev_id used
> during request_irq().
> 
> Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
> Signed-off-by: Kery Qi <qikeyu2017@...il.com>

Thanks, I agree with your analysis; that the problem was introduced
by the cited commit; and the proposed fixes.

Reviewed-by: Simon Horman <horms@...nel.org>

Some notes on procedure For reference, if you post more networking fixes,
or need to spin this patch for some reason.

1. As a bug fix for code present in the net tree it should be
   targeted at that tree.

   Subject: [PATCH net] ...

2. Please include all maintainers and the patch author of the author commit.
   "./scripts/get_maintainer.pl this.patch" can with that.

3. For bug fixes, please consider the guidelines for stable submissions.
   I.e. CC; stable@...r.kernel.org

See also: https://docs.kernel.org/process/maintainer-netdev.html