[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com>
Date: Mon, 12 Jan 2026 11:16:20 +0200
From: Tariq Toukan <tariqt@...dia.com>
To: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
S. Miller" <davem@...emloft.net>
CC: Jian Shen <shenjian15@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
Jijie Shao <shaojijie@...wei.com>, Saeed Mahameed <saeedm@...dia.com>, "Tariq
Toukan" <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>, Leon Romanovsky
<leon@...nel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-rdma@...r.kernel.org>, Gal Pressman <gal@...dia.com>, Moshe Shemesh
<moshe@...dia.com>, Shahar Shitrit <shshitrit@...dia.com>, Yael Chemla
<ychemla@...dia.com>, Jamal Hadi Salim <jhs@...atatu.com>
Subject: [PATCH net-next V2 0/3] Introduce and use netif_xmit_timeout_ms() helper
Hi,
This is V2, find V1 here:
https://lore.kernel.org/all/1764054776-1308696-1-git-send-email-tariqt@nvidia.com/
This series by Shahar introduces a new helper function
netif_xmit_timeout_ms() to check if a TX queue has timed out and report
the timeout duration.
It also encapsulates the check for whether the TX queue is stopped.
Replace duplicated open-coded timeout check in hns3 driver with the new
helper.
For mlx5e, refine the TX timeout recovery flow to act only on SQs whose
transmit timestamp indicates an actual timeout, as determined by the
helper. This prevents unnecessary channel reopen events caused by
attempting recovery on queues that are merely stopped but not truly
timed out.
Regards,
Tariq
V2:
- Rebase.
- Move helper to include/net/netdev_queues.h.
- Remove output paramter trans_start from the new helper.
- Revert the code in dev_watchdog to not use the helper.
- Fix the helper name in commit message.
Shahar Shitrit (3):
net: Introduce netif_xmit_timeout_ms() helper
net: hns3: Use netif_xmit_timeout_ms() helper
net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++++-------
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
include/net/netdev_queues.h | 11 +++++++++++
3 files changed, 17 insertions(+), 8 deletions(-)
base-commit: 60d8484c4cec811f5ceb6550655df74490d1a165
--
2.31.1
Powered by blists - more mailing lists