netdev - Re: [net-next,v3,11/13] octeontx2-pf: cn20k: Add TC rules support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWYWVk8sQ1Ei-_x7@rkannoth-OptiPlex-7090>
Date: Tue, 13 Jan 2026 15:24:30 +0530
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next,v3,11/13] octeontx2-pf: cn20k: Add TC rules support

On 2026-01-11 at 04:29:36, Jakub Kicinski (kuba@...nel.org) wrote:
> > +		entry = node->entry;
> > +		goto free_mcam_entry;
> > +	}
>
> [ ... ]
>
> > +free_mcam_entry:
> > +	if (cn20k_tc_free_mcam_entry(nic, entry))
> > +		netdev_err(nic->netdev, "Freeing entry %d to AF failed\n",
> > +			   first->entry);
>                            ^^^^^^^^^^^^
>
> Should this error message print 'entry' instead of 'first->entry'? When
> the code takes the "not shiftable" path, it sets entry = node->entry and
> jumps to free_mcam_entry. At that point, first->entry may be different
> from the entry value that was actually passed to cn20k_tc_free_mcam_entry().
>
ACK
> > +}