netdev - RE: [PATCH iwl-next v1 5/7] ixgbe: move EEE config validation out of ixgbe_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB590206D74638658471D9964FF08EA@PH0PR11MB5902.namprd11.prod.outlook.com>
Date: Tue, 13 Jan 2026 12:42:34 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>
Subject: RE: [PATCH iwl-next v1 5/7] ixgbe: move EEE config validation out of
 ixgbe_set_eee()

From: Andrew Lunn <andrew@...n.ch> 
Sent: Monday, January 12, 2026 4:33 PM

> +	if (keee_stored.eee_enabled == keee_requested->eee_enabled)
> +		return -EALREADY;
>
> know this is just moving code around, but i don't know of any other
>mplementation of EEE which returns -EALREADY when no change has been
>equested by the user. Maybe in a follow up patch you change this to 0?
>
>	  Andrew

EALREADY is used here just for internal purpose to save some work.
Then we can have single input validation function and provide info
to the actual ethtool callback that it can early bail out.
Driver doesn't send EALREADY to ethtool, it's later replaced with 0.