netdev - Re: [PATCH net-next v2 2/2] selftests: net: improve error handling in passive TFO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <607a0338-5e84-4aaf-b705-18dcd4aca05f@web.de>
Date: Tue, 13 Jan 2026 15:48:11 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Yohei Kojima <yk@...oj.net>, linux-kselftest@...r.kernel.org,
 netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net-next v2 2/2] selftests: net: improve error handling in
 passive TFO test

…
> +++ b/tools/testing/selftests/net/tfo.c
> @@ -82,8 +82,10 @@ static void run_server(void)
…
>  	if (read(connfd, buf, 64) < 0)
> -		perror("read()");
> -	fprintf(outfile, "%d\n", opt);
> +		error(1, errno, "read()");
> +
> +	if (fprintf(outfile, "%d\n", opt) < 0)
> +		error(1, errno, "fprintf()");
>  
>  	fclose(outfile);
>  	close(connfd);
…

Why was error detection omitted for close() calls here so far?

https://pubs.opengroup.org/onlinepubs/9799919799/functions/fclose.html

Regards,
Markus