netdev - Re: [PATCH v1 net] l2tp: Fix memleak in l2tp_udp_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWaZdj7VcRCOK869@debian>
Date: Tue, 13 Jan 2026 20:13:58 +0100
From: Guillaume Nault <gnault@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
	syzbot+2c42ea4485b29beb0643@...kaller.appspotmail.com
Subject: Re: [PATCH v1 net] l2tp: Fix memleak in l2tp_udp_encap_recv().

On Tue, Jan 13, 2026 at 06:54:44PM +0000, Kuniyuki Iwashima wrote:
> syzbot reported memleak of struct l2tp_session, l2tp_tunnel,
> sock, etc. [0]
> 
> The cited commit moved down the validation of the protocol
> version in l2tp_udp_encap_recv().
> 
> The new place requires an extra error handling to avoid the
> memleak.
> 
> Let's call l2tp_session_put() there.

Reviewed-by: Guillaume Nault <gnault@...hat.com>